changeset 1de300588c4f in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=1de300588c4f
description:
mem: Remove unused RequestState in the bridge
This patch removes the bridge sender state as the Crossbar now takes
care of remembering its own routing decisions.
diffstat:
src/mem/bridge.cc | 22 ----------------------
src/mem/bridge.hh | 17 -----------------
2 files changed, 0 insertions(+), 39 deletions(-)
diffs (66 lines):
diff -r 8bb4a9717eaa -r 1de300588c4f src/mem/bridge.cc
--- a/src/mem/bridge.cc Thu Jan 22 05:01:24 2015 -0500
+++ b/src/mem/bridge.cc Thu Jan 22 05:01:27 2015 -0500
@@ -207,15 +207,6 @@
void
Bridge::BridgeMasterPort::schedTimingReq(PacketPtr pkt, Tick when)
{
- // If we expect to see a response, we need to restore the source
- // and destination field that is potentially changed by a second
- // crossbar
- if (!pkt->memInhibitAsserted() && pkt->needsResponse()) {
- // Update the sender state so we can deal with the response
- // appropriately
- pkt->pushSenderState(new RequestState(pkt->getSrc()));
- }
-
// If we're about to put this packet at the head of the queue, we
// need to schedule an event to do the transmit. Otherwise there
// should already be an event scheduled for sending the head
@@ -233,19 +224,6 @@
void
Bridge::BridgeSlavePort::schedTimingResp(PacketPtr pkt, Tick when)
{
- // This is a response for a request we forwarded earlier. The
- // corresponding request state should be stored in the packet's
- // senderState field.
- RequestState *req_state =
- dynamic_cast<RequestState*>(pkt->popSenderState());
- assert(req_state != NULL);
- pkt->setDest(req_state->origSrc);
- delete req_state;
-
- // the bridge sets the destination irrespective of it is valid or
- // not, as it is checked in the crossbar
- DPRINTF(Bridge, "response, new dest %d\n", pkt->getDest());
-
// If we're about to put this packet at the head of the queue, we
// need to schedule an event to do the transmit. Otherwise there
// should already be an event scheduled for sending the head
diff -r 8bb4a9717eaa -r 1de300588c4f src/mem/bridge.hh
--- a/src/mem/bridge.hh Thu Jan 22 05:01:24 2015 -0500
+++ b/src/mem/bridge.hh Thu Jan 22 05:01:27 2015 -0500
@@ -75,23 +75,6 @@
protected:
/**
- * A bridge request state stores packets along with their sender
- * state and original source. It has enough information to also
- * restore the response once it comes back to the bridge.
- */
- class RequestState : public Packet::SenderState
- {
-
- public:
-
- const PortID origSrc;
-
- RequestState(PortID orig_src) : origSrc(orig_src)
- { }
-
- };
-
- /**
* A deferred packet stores a packet along with its scheduled
* transmission time
*/
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
