----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2619/#review5800 -----------------------------------------------------------
Thanks for the patch. Great addition! Did you use the reviewboard extension (and hg postreview -o)? Somehow the diff does not seem to apply. Also, the summary should probably be "cpu: Add L-TAGE branch predictor", and the other bits should go in the patch description. - Andreas Hansson On Jan. 26, 2015, 11:52 p.m., Dibakar Gope wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2619/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2015, 11:52 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > It is the L-TAGE predictor from the Branch Prediction Championship, > originally coded by Vignyan Reddy, and modified by me. > > > Diffs > ----- > > src/cpu/pred/2bit_local.hh 2051d6b87b53 > src/cpu/pred/2bit_local.cc 2051d6b87b53 > src/cpu/pred/BranchPredictor.py 2051d6b87b53 > src/cpu/pred/SConscript 2051d6b87b53 > src/cpu/pred/bi_mode.hh 2051d6b87b53 > src/cpu/pred/bi_mode.cc 2051d6b87b53 > src/cpu/pred/bpred_unit.hh 2051d6b87b53 > src/cpu/pred/bpred_unit.cc 2051d6b87b53 > src/cpu/pred/bpred_unit_impl.hh 2051d6b87b53 > src/cpu/pred/ltage.hh PRE-CREATION > src/cpu/pred/ltage.cc PRE-CREATION > src/cpu/pred/tournament.hh 2051d6b87b53 > src/cpu/pred/tournament.cc 2051d6b87b53 > > Diff: http://reviews.gem5.org/r/2619/diff/ > > > Testing > ------- > > > Thanks, > > Dibakar Gope > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
