----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2620/#review5801 -----------------------------------------------------------
Ship it! Much more simple than I thought it would be. Thanks for the quick turn-around. Everything checks out on my end. - Jason Power On Jan. 27, 2015, 10:19 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2620/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2015, 10:19 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10682:8198d3eedca6 > --------------------------- > cpu: Ensure timing CPU sinks response before sending new request > > This patch changes how the timing CPU deals with processing responses, > always scheduling an event, even if it is for the current tick. This > helps to avoid situations where a new request shows up before a > response is finished in the crossbar, and also is more in line with > any realistic behaviour. > > > Diffs > ----- > > src/cpu/simple/timing.cc 3c42be107634 > > Diff: http://reviews.gem5.org/r/2620/diff/ > > > Testing > ------- > > All regressions pass. > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
