----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2627/#review5828 -----------------------------------------------------------
src/mem/ruby/system/DMASequencer.hh <http://reviews.gem5.org/r/2627/#comment5138> Can we not get this through the sequencer rather? src/mem/ruby/system/DMASequencer.cc <http://reviews.gem5.org/r/2627/#comment5142> Should this really be functional, or should it just be "access"? src/mem/ruby/system/RubySystem.py <http://reviews.gem5.org/r/2627/#comment5139> I find the description rather misleading. In essence it is not the case of bypassing the interconnect, it is more a case of duplicating the memory, and ignoring the "normal" one. Thinking about it, why do we not just use the actual memory, but do so by faking it through system->getPhysMem().access(...) src/mem/ruby/system/System.hh <http://reviews.gem5.org/r/2627/#comment5141> const src/mem/ruby/system/System.hh <http://reviews.gem5.org/r/2627/#comment5140> const - Andreas Hansson On Feb. 4, 2015, 11:31 p.m., Jason Power wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2627/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 11:31 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10681:b2dc4aee1a0d > --------------------------- > Ruby: Update backing store option to propagate through to all RubyPorts > > Previously, the user would have to manually set access_backing_store=True > on all RubyPorts (Sequencers) in the config files. > Now, instead there is one global option that each RubyPort checks on > initialization. > > > Diffs > ----- > > configs/ruby/Ruby.py 7639c17357dc > src/mem/ruby/system/DMASequencer.hh 7639c17357dc > src/mem/ruby/system/DMASequencer.cc 7639c17357dc > src/mem/ruby/system/RubyPort.cc 7639c17357dc > src/mem/ruby/system/RubySystem.py 7639c17357dc > src/mem/ruby/system/Sequencer.py 7639c17357dc > src/mem/ruby/system/System.hh 7639c17357dc > src/mem/ruby/system/System.cc 7639c17357dc > > Diff: http://reviews.gem5.org/r/2627/diff/ > > > Testing > ------- > > > Thanks, > > Jason Power > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
