----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2633/#review5834 -----------------------------------------------------------
Ship it! Ship It! - Steve Reinhardt On Feb. 5, 2015, 3:36 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2633/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2015, 3:36 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10694:c953f9d91908 > --------------------------- > base: Do not dereference NULL in CompoundFlag creation > > This patch fixes the CompoundFlag constructor, ensuring that it does > not dereference NULL. Doing so has undefined behaviuor, and both clang > and gcc's undefined-behaviour sanitiser was rather unhappy. > > > Diffs > ----- > > src/SConscript 7639c17357dc > src/base/debug.hh 7639c17357dc > > Diff: http://reviews.gem5.org/r/2633/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
