----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2635/#review5841 -----------------------------------------------------------
Ship it! Ship It! - Steve Reinhardt On Feb. 5, 2015, 4:52 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2635/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2015, 4:52 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10701:7aa9b19210a0 > --------------------------- > mem: Clarification of packet crossbar timings > > This patch clarifies the packet timings annotated > when going through a crossbar. > > The old 'firstWordDelay' is replaced by 'headerDelay' that represents > the delay associated to the delivery of the header of the packet. > > The old 'lastWordDelay' is replaced by 'payloadDelay' that represents > the delay needed to processing the payload of the packet. > > For now the uses and values remain identical. However, going forward > the payloadDelay will be additive, and not include the > headerDelay. Follow-on patches will make the headerDelay capture the > pipeline latency incurred in the crossbar, whereas the payloadDelay > will capture the additional serialisation delay. > > > Diffs > ----- > > src/arch/x86/pagetable_walker.cc 7639c17357dc > src/dev/io_device.cc 7639c17357dc > src/dev/pcidev.cc 7639c17357dc > src/dev/x86/intdev.hh 7639c17357dc > src/mem/bridge.cc 7639c17357dc > src/mem/cache/cache_impl.hh 7639c17357dc > src/mem/coherent_xbar.cc 7639c17357dc > src/mem/dram_ctrl.cc 7639c17357dc > src/mem/dramsim2.cc 7639c17357dc > src/mem/external_slave.cc 7639c17357dc > src/mem/noncoherent_xbar.cc 7639c17357dc > src/mem/packet.hh 7639c17357dc > src/mem/simple_mem.cc 7639c17357dc > src/mem/xbar.hh 7639c17357dc > src/mem/xbar.cc 7639c17357dc > > Diff: http://reviews.gem5.org/r/2635/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
