----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2637/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 10684:ded42ff6f410 --------------------------- mem: clean up write buffer check in Cache::handleSnoop() The 'if (writebacks.size)' check was redundant, because writeBuffer.findMatches() would return false if the writebacks list was empty. Also renamed 'mshr' to 'wb_entry' in this context since we are pointing at a writebuffer entry and not an MSHR (even though it's the same C++ class). Diffs ----- src/mem/cache/cache_impl.hh 3d17366c0423a59478ae63d40c8feeea34df218a Diff: http://reviews.gem5.org/r/2637/diff/ Testing ------- Thanks, Steve Reinhardt _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
