----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2626/#review5860 -----------------------------------------------------------
Ship it! Minor optional comments below... configs/example/memcheck.py <http://reviews.gem5.org/r/2626/#comment5157> If you build and populate a SimObjectVector, then assign it to its config hierarchy parent, this problem will take care of itself. Or you can take the solution used there and copy it, see http://repo.gem5.org/gem5/file/3d17366c0423/src/python/m5/params.py#l269 configs/example/memcheck.py <http://reviews.gem5.org/r/2626/#comment5155> seems like you don't need this check anymore, right? might want to leave it in if you agree that memtest.py should be merged in here - Steve Reinhardt On Feb. 3, 2015, 11:57 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2626/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2015, 11:57 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10692:f0a93f672561 > --------------------------- > config: Add memcheck stress test > > This is a rather unfortunate copy of the memtest.py example script, > that actually stresses the system with true sharing as opposed to the > false sharing of the MemTest. To do so it uses TrafficGen instances to > generate the reads/writes, and MemCheckerMonitor combined with the > MemChecker to check the validity of the read/written values. > > As a bonus, this script also enables the addition of prefetchers, and > the traffic is created to have a mix of random addresses and linear > strides. We use the TaggedPrefetcher since the packets do not have a > request with a PC. > > At the moment the code is almost identical to the memtest.py script, > and no effort has been made to factor out the construction of the > tree. The challenge is that the instantiation and connection of the > testers and monitors is done as part of the tree building. > > > Diffs > ----- > > configs/example/memcheck.py PRE-CREATION > > Diff: http://reviews.gem5.org/r/2626/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
