----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2640/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 10684:d5f452edcf9c --------------------------- cpu: remove conditional check (count > 0) on o3 IQ squashes The o3 cpu instruction queue model uses the count variable to track the number of unissued instructions in the queue. Previously, the squash method used this variable to avoid executing the doSquash method when there were no unissued instructions in the pipeline. A corner case problem exists when only issued instructions exist in the pipeline and a squash occurs; the doSquash code is not invoked and subsequently does not clean up state properly. Diffs ----- src/cpu/o3/inst_queue_impl.hh 3d17366c0423a59478ae63d40c8feeea34df218a Diff: http://reviews.gem5.org/r/2640/diff/ Testing ------- Thanks, Brandon Potter _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
