----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2649/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 10684:39b06818b9a6 --------------------------- mem: restructure Packet cmd initialization a bit more Refactor the way that specific MemCmd values are generated for packets. The new approach is a little more elegant in that we assign the right value up front, and it's also more amenable to non-heap-allocated Packet objects. Also replaced the code in the Minor model that was still doing it the ad-hoc way. This is basically a refinement of http://repo.gem5.org/gem5/rev/711eb0e64249 Diffs ----- src/cpu/inorder/resources/cache_unit.hh 94901e131a7f2452b3cf2b2740be866b4a6f404d src/cpu/inorder/resources/cache_unit.cc 94901e131a7f2452b3cf2b2740be866b4a6f404d src/cpu/minor/lsq.cc 94901e131a7f2452b3cf2b2740be866b4a6f404d src/cpu/simple/atomic.cc 94901e131a7f2452b3cf2b2740be866b4a6f404d src/mem/packet.hh 94901e131a7f2452b3cf2b2740be866b4a6f404d Diff: http://reviews.gem5.org/r/2649/diff/ Testing ------- Thanks, Steve Reinhardt _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
