----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2651/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 10686:7fc1f2b733cf --------------------------- cache: remove redundant test in recvTimingResp() For some reason we were checking mshr->hasTargets() even though we had already called mshr->getTarget() unconditionally earlier in the same function (which asserts if there are no targets). Get rid of this useless check, and while we're at it get rid of the redundant call to mshr->getTarget(), since we still have the value saved in a local var. Diffs ----- src/mem/cache/cache_impl.hh 94901e131a7f2452b3cf2b2740be866b4a6f404d Diff: http://reviews.gem5.org/r/2651/diff/ Testing ------- Thanks, Steve Reinhardt _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
