> On Feb. 9, 2015, 9:43 p.m., Joel Hestness wrote: > > src/mem/ruby/system/System.cc, line 156 > > <http://reviews.gem5.org/r/2627/diff/4/?file=43679#file43679line156> > > > > This doesn't seem right. m_phys_mem is SimpleMemory type, which > > inherits empty serialize()/unserialize() functions from the Serializable > > class. Thus, this code doesn't do anything except add the fake backing > > store header to the checkpoint. > > > > Can you elaborate on the situation that suggested you needed this?
This check is required since m_phys_mem is null when m_access_backing_store is false. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2627/#review5879 ----------------------------------------------------------- On Feb. 9, 2015, 8 p.m., Jason Power wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2627/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2015, 8 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10681:b2dc4aee1a0d > --------------------------- > Ruby: Update backing store option to propagate through to all RubyPorts > > Previously, the user would have to manually set access_backing_store=True > on all RubyPorts (Sequencers) in the config files. > Now, instead there is one global option that each RubyPort checks on > initialization. > > > Diffs > ----- > > configs/ruby/Ruby.py 7639c17357dc > src/mem/ruby/system/DMASequencer.hh 7639c17357dc > src/mem/ruby/system/DMASequencer.cc 7639c17357dc > src/mem/ruby/system/RubyPort.cc 7639c17357dc > src/mem/ruby/system/RubySystem.py 7639c17357dc > src/mem/ruby/system/Sequencer.py 7639c17357dc > src/mem/ruby/system/System.hh 7639c17357dc > src/mem/ruby/system/System.cc 7639c17357dc > > Diff: http://reviews.gem5.org/r/2627/diff/ > > > Testing > ------- > > > Thanks, > > Jason Power > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
