----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2664/ -----------------------------------------------------------
(Updated Feb. 23, 2015, 1:04 p.m.) Review request for Default. Repository: gem5 Description (updated) ------- Changeset 10722:366b2fa691b7 --------------------------- mem: Add byte mask to Packet::checkFunctional This patch changes the valid-bytes start/end to a proper byte mask. With the changes in timing introduced in previous patches there are more packets waiting in queues, and there are regressions using the checker CPU failing due to non-contigous read data being found in the various cache queues. This patch also adds some more comments explaining what is going on, and adds the fourth and missing case to Packet::checkFunctional. Diffs (updated) ----- src/mem/packet.cc c6cb94a14fea src/mem/packet.hh c6cb94a14fea Diff: http://reviews.gem5.org/r/2664/diff/ Testing ------- Thanks, Andreas Hansson _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
