----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2670/#review5915 -----------------------------------------------------------
Ship it! Ship It! - Steve Reinhardt On Feb. 23, 2015, 5:05 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2670/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2015, 5:05 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10723:a8355eea658c > --------------------------- > mem: Fix cache MSHR conflict determination > > This patch fixes a rather subtle issue in the sending of MSHR requests > in the cache, where the logic previously did not check for conflicts > between the MSRH queue and the write queue when requests were not > ready. The correct thing to do is to always check, since not having a > ready MSHR does not guarantee that there is no conflict. > > The underlying problem seems to have slipped past due to the symmetric > timings used for the write queue and MSHR queue. However, with the > recent timing changes the bug caused regressions to fail. > > > Diffs > ----- > > src/mem/cache/cache_impl.hh c6cb94a14fea > > Diff: http://reviews.gem5.org/r/2670/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
