Hi Nilay, I don’t think anyone is suggesting a general split between function and stats gathering. The whole point with putting stats in probes is compartmentalisation. We already have problems with too many stats, and while some stats definitely make sense as part of the running code, bigger bundles of isolated functionality are probably better of as probes (a CPI probe, trace probes etc). Needless to say the probe infrastructure is very useful for things other than bundling up of stats as well.
The specific patch (#2680) is probably a borderline case, and I am not suggesting it has to be a probe, I am merely arguing that we should consider it, and not just blindly add more stats since we already have issues with the signal-to-noise ratio. Andreas On 05/03/2015 04:56, "Nilay Vaish" <[email protected]> wrote: >On Wed, 4 Mar 2015, Andreas Hansson wrote: > >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> http://reviews.gem5.org/r/2680/#review5937 >> ----------------------------------------------------------- >> >> >> Should this perhaps be a probe rather? >> > >OK, I just read the commit message from the changeset 10023 91faf6649de0. >I am going to argue against separating statistics gathering from the so >called functional code. One of the ways I use to learn gem5 (or have >used) is observing how the statistics are being collected. Moving >statistics collection to a separate file, makes that collection code less >visible, which is as important as the functional code itself. This >approach was being used in ruby originally. And I changed it (changeset >67d9da312ef0) so that a person reading the code knows what statistic is >being updated when. > >-- >Nilay > -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2557590 ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No: 2548782 _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
