On Fri, 6 Mar 2015, Dibakar Gope wrote:
On March 4, 2015, 6:54 p.m., Nilay Vaish wrote:
OK. I am sorry for not realizing that so many changes would be required to
separate out
the params just meant for LTAGE. Had I had realized that, I probably would not
have asked for it.
I think we should break this latest version into two separate patches. The
first patch
creates these separate sim objects for different predictor types. The second
patch adds LTAGE.
And I am willing to go with either order between those two patches. That is,
if you prefer, you
can add LTAGE first and then separate out the predictors.
Revised patches, bpred_reorg.patch (separate patch) just re-organizes the
branch predictor structure. The ltage patch applies on top of that.
ltage.cc and ltage.hh is primarily Andre Seznec's code from branch
prediction championship, that code uploaded on the championship website
had no copyright on it. Vignyan later edited that code to handle
rollback etc while he was at University of Wisconsin-Madison. So I add
the copyright as "* Copyright (c) 2014 The University of Wisconsin" at
the top of ltage.cc and ltage.hh and leaving that to the review forum to
decide on the copyrights of these two files.
Dibakar, can you contact Andre and ask him if he is willing to contribute
this code to gem5? Provide him a copy of the license gem5 carries and ask
him if he is fine with it or would he prefer some other license? Also ask
him under whose copyright would he be willing to publish this code.
I think we are not right in discussing this code without Andre's
permission. I am deleting this review request. If Andre agrees, repost
the patch. I'll leave the reorg patch as is.
--
Nilay
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
