changeset 655ff3f6352d in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=655ff3f6352d
description:
mem: remove redundant test in in Cache::recvTimingResp()
For some reason we were checking mshr->hasTargets() even though
we had already called mshr->getTarget() unconditionally earlier
in the same function (which asserts if there are no targets).
Get rid of this useless check, and while we're at it get rid
of the redundant call to mshr->getTarget(), since we still have
the value saved in a local var.
diffstat:
src/mem/cache/cache_impl.hh | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
diffs (16 lines):
diff -r 88d515925cbf -r 655ff3f6352d src/mem/cache/cache_impl.hh
--- a/src/mem/cache/cache_impl.hh Wed Feb 11 10:48:52 2015 -0800
+++ b/src/mem/cache/cache_impl.hh Wed Feb 11 10:48:53 2015 -0800
@@ -1128,11 +1128,7 @@
}
// First offset for critical word first calculations
- int initial_offset = 0;
-
- if (mshr->hasTargets()) {
- initial_offset = mshr->getTarget()->pkt->getOffset(blkSize);
- }
+ int initial_offset = initial_tgt->pkt->getOffset(blkSize);
while (mshr->hasTargets()) {
MSHR::Target *target = mshr->getTarget();
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
