----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2697/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 10754:1675912d09bf --------------------------- mem: Ignore uncacheable MSHRs when finding matches This patch changes how we search for matching MSHRs, ignoring any MSHR that is allocated for an uncacheable access. By doing so, this patch fixes a corner case in the MSHRs where incorrect data ended up being copied into a (cacheable) read packet due to a first uncacheable MSHR target of size 4, followed by a cacheable target to the same MSHR of size 64. The latter target was filled with nonsense data. Diffs ----- src/mem/cache/mshr_queue.cc 655ff3f6352d src/mem/cache/mshr.cc 655ff3f6352d Diff: http://reviews.gem5.org/r/2697/diff/ Testing ------- Thanks, Andreas Hansson _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
