> On March 21, 2015, 1:32 p.m., Andreas Hansson wrote: > > I like the idea of getting it sorted (hopefully we can retire the > > RubyMemoryControl). I am not sure about the solution though. Surely all the > > stats for the DRAMCtrl object(s) would be all confused if time advances, > > but no accesses are counted? Do we not also need to reset all stats once > > the warmup is sorted?
I was under the impression that the stats are already reset after the warmup completes. Is this incorrect? - Lena ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2702/#review5956 ----------------------------------------------------------- On March 21, 2015, 7:11 p.m., Lena Olson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2702/ > ----------------------------------------------------------- > > (Updated March 21, 2015, 7:11 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10743:d3ead01d8747 > --------------------------- > ruby: allow restoring from checkpoint when using DRAMCtrl > > Restoring from a checkpoint with ruby + the DRAMCtrl memory model > was not working, because ruby and DRAMCtrl disagreed on the > current tick during warmup. Since there is no reason to do > timing requests during warmup, use functional requests instead. > > > Diffs > ----- > > src/mem/ruby/slicc_interface/AbstractController.hh 655ff3f6352d > src/mem/ruby/slicc_interface/AbstractController.cc 655ff3f6352d > > Diff: http://reviews.gem5.org/r/2702/diff/ > > > Testing > ------- > > Can now restore checkpoints in X86+MOESI hammer+DRAMCtrl. It also still > works with simple mem, which was working before. > > > Thanks, > > Lena Olson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
