----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2722/#review5986 -----------------------------------------------------------
Ship it! src/arch/x86/isa/formats/monitor_mwait.isa <http://reviews.gem5.org/r/2722/#comment5221> please put a space after '//' - Steve Reinhardt On March 30, 2015, 2:37 p.m., Lena Olson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2722/ > ----------------------------------------------------------- > > (Updated March 30, 2015, 2:37 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10743:1cabbb0e1e44 > --------------------------- > x86: fix debug trace output for mwait > > When running with the Exec flag, the mwait instruction attempted > to print out its source registers, which were never actually > initialized. This led to sporadic assertion failures when the > value stored there was invalid. > > > Diffs > ----- > > src/arch/x86/isa/formats/monitor_mwait.isa 655ff3f6352d > > Diff: http://reviews.gem5.org/r/2722/diff/ > > > Testing > ------- > > > Thanks, > > Lena Olson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
