----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2726/#review6027 -----------------------------------------------------------
Ship it! Ship It! - Nilay Vaish On April 2, 2015, 3:47 p.m., Steve Reinhardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2726/ > ----------------------------------------------------------- > > (Updated April 2, 2015, 3:47 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10773:20d671d6ee6d > --------------------------- > syscall_emul: fix warn_once behavior > > The current ignoreWarnOnceFunc doesn't really work as expected, > since it will only generate one warning total, for whichever > "warn-once" syscall is invoked first. This patch fixes that > behavior by keeping a "warned" flag in the SyscallDesc object, > allowing suitably flagged syscalls to warn exactly once per > syscall. > > > Diffs > ----- > > src/arch/arm/linux/process.cc 8a7285d6197eb0d8f1642e6cdb7a21aa1ff6310e > src/arch/x86/linux/process.cc 8a7285d6197eb0d8f1642e6cdb7a21aa1ff6310e > src/sim/syscall_emul.hh 8a7285d6197eb0d8f1642e6cdb7a21aa1ff6310e > src/sim/syscall_emul.cc 8a7285d6197eb0d8f1642e6cdb7a21aa1ff6310e > > Diff: http://reviews.gem5.org/r/2726/diff/ > > > Testing > ------- > > > Thanks, > > Steve Reinhardt > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
