----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2748/#review6087 -----------------------------------------------------------
src/mem/ruby/common/Set.hh (line 69) <http://reviews.gem5.org/r/2748/#comment5294> Exceeds the 79 char limit. - Brad Beckmann On April 27, 2015, 7:22 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2748/ > ----------------------------------------------------------- > > (Updated April 27, 2015, 7:22 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10810:40bef246bc7a > --------------------------- > ruby: set: replace long by unsigned long > UBSan complains about negative value being shifted > > > Diffs > ----- > > src/mem/ruby/common/Set.hh df2aa91dba5b > src/mem/ruby/common/Set.cc df2aa91dba5b > > Diff: http://reviews.gem5.org/r/2748/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
