----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2717/#review6103 -----------------------------------------------------------
Ship it! Looks great! Thanks for the changes! - Steve Reinhardt On April 23, 2015, 2:35 p.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2717/ > ----------------------------------------------------------- > > (Updated April 23, 2015, 2:35 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10809:4bff2588b9b0 > --------------------------- > mem: Snoop into caches on uncacheable accesses > > This patch takes a last step in fixing issues related to uncacheable > accesses. We do not separate uncacheable memory from uncacheable > devices, and in cases where it is really memory, there are valid > scenarios where we need to snoop since we do not support cache > maintenance instructions (yet). On snooping an uncacheable access we > thus provide data if possible. In essence this makes uncacheable > accesses IO coherent. > > The snoop filter is also queried to steer the snoops, but not updated > since the uncacheable accesses do not allocate a block. > > > Diffs > ----- > > src/mem/cache/base.cc 876341add7be > src/mem/cache/cache_impl.hh 876341add7be > src/mem/cache/mshr.cc 876341add7be > src/mem/coherent_xbar.cc 876341add7be > src/mem/snoop_filter.cc 876341add7be > src/dev/dma_device.cc 876341add7be > src/mem/cache/base.hh 876341add7be > src/cpu/o3/cpu.cc 876341add7be > > Diff: http://reviews.gem5.org/r/2717/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
