This seems pretty relevant: http://scons.tigris.org/issues/show_bug.cgi?id=2815
Not sure if that patch is in any more recent releases or not. Steve On Mon, May 4, 2015 at 10:07 AM, Ruslan Bukin <[email protected]> wrote: > I agree that solution provided is not perfect, but it works and I > was not lucky to find the roots of problem -- it seems the swig executable > filename is hardcoded somewhere in scons library > > Ruslan > > On Mon, May 04, 2015 at 10:10:16AM -0700, Steve Reinhardt wrote: > > Note that we have an explicit check for CC and CXX on line 235, which is > > why get() is unnecessary for those. > > > > In general, I agree that the handling for SWIG should be more similar to > CC > > and CXX, and I don't get why this patch seems to make it more different > > instead of more similar. > > > > Is this a bug in scons's swig support, rather than a problem with our > > SConstruct? > > > > Steve > > > > On Mon, May 4, 2015 at 9:59 AM, Ruslan Bukin <[email protected]> wrote: > > > > > > > > > > > > On May 4, 2015, 4:12 p.m., Nilay Vaish wrote: > > > > > SConstruct, line 403 > > > > > < > http://reviews.gem5.org/r/2752/diff/1/?file=44838#file44838line403> > > > > > > > > > > What happens differently here? Just looking at the code, I > would > > > assume that the operator [] behaves same as get() function. > > > > > > > > Ruslan Bukin wrote: > > > > [key] produce exception if there is no such key, get(key) returns > > > None in such situation > > > > > > > > Andreas Hansson wrote: > > > > Does that mean they should all use get? It seems odd to me that > SWIG > > > should be any different from the other build tools. > > > > > > yes, make sense > > > > > > > > > - Ruslan > > > > > > > > > ----------------------------------------------------------- > > > This is an automatically generated e-mail. To reply, visit: > > > http://reviews.gem5.org/r/2752/#review6114 > > > ----------------------------------------------------------- > > > > > > > > > On April 30, 2015, 1:44 p.m., Ruslan Bukin wrote: > > > > > > > > ----------------------------------------------------------- > > > > This is an automatically generated e-mail. To reply, visit: > > > > http://reviews.gem5.org/r/2752/ > > > > ----------------------------------------------------------- > > > > > > > > (Updated April 30, 2015, 1:44 p.m.) > > > > > > > > > > > > Review request for Default, Ali Saidi and Nilay Vaish. > > > > > > > > > > > > Repository: gem5 > > > > > > > > > > > > Description > > > > ------- > > > > > > > > Default swig binary filename in FreeBSD is 'swig2.0' > > > > but build system only look for 'swig'. > > > > > > > > This allows to specify correct name like: > > > > export SWIG=/usr/local/bin/swig2.0 > > > > > > > > > > > > Diffs > > > > ----- > > > > > > > > SConstruct 74e3c7359393 > > > > > > > > Diff: http://reviews.gem5.org/r/2752/diff/ > > > > > > > > > > > > Testing > > > > ------- > > > > > > > > tested on FreeBSD only. > > > > > > > > > > > > Thanks, > > > > > > > > Ruslan Bukin > > > > > > > > > > > > > > _______________________________________________ > > > gem5-dev mailing list > > > [email protected] > > > http://m5sim.org/mailman/listinfo/gem5-dev > > > > > _______________________________________________ > > gem5-dev mailing list > > [email protected] > > http://m5sim.org/mailman/listinfo/gem5-dev > > _______________________________________________ > gem5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/gem5-dev > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
