----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2766/#review6126 -----------------------------------------------------------
Ship it! Ship It! - Steve Reinhardt On May 8, 2015, 6:10 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2766/ > ----------------------------------------------------------- > > (Updated May 8, 2015, 6:10 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10832:4d7b7d5e972d > --------------------------- > misc: Appease gcc 5.1 > > Three minor issues are resolved: > > 1. Apparently gcc 5.1 does not like negation of booleans followed by > bitwise AND. > > 2. Somehow the compiler also gets confused and warns about > NoopMachInst being unused (removing it causes compilation errors > though). Most likely a compiler bug. > > 3. There seems to be a number of instances where loop unrolling causes > false positives for the array-bounds check. For now, switch to > std::array. Potentially we could disable the warning for newer gcc > versions, but switching to std::array is probably a good move in > any case. > > > Diffs > ----- > > src/arch/x86/insts/microop.cc fbdaa08aaa42 > src/arch/x86/isa_traits.hh fbdaa08aaa42 > src/cpu/base_dyn_inst.hh fbdaa08aaa42 > src/cpu/o3/dyn_inst.hh fbdaa08aaa42 > > Diff: http://reviews.gem5.org/r/2766/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
