Hi Nilay, Can you check this patch and the previous patch (review 2550) in the repo? We will be posting a series of patches next week and they depend on these two patches.
Thanks, Brad From: Brad Beckmann [mailto:[email protected]] On Behalf Of Beckmann, Brad Sent: Monday, April 27, 2015 3:30 PM To: Nilay Vaish; Beckmann, Brad; Default Subject: Re: Review Request 2551: ruby: slicc: have a static MachineType This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2551/ Ship it! Ship It! - Brad Beckmann On December 4th, 2014, 6:08 p.m. UTC, Nilay Vaish wrote: Review request for Default. By Nilay Vaish. Updated Dec. 4, 2014, 6:08 p.m. Repository: gem5 Description Changeset 10594:b25131489b95 --------------------------- ruby: slicc: have a static MachineType This patch moves from a dynamically defined MachineType to a statically defined one. The need for this patch was felt since a dynamically defined type prevents us from having types for which no machine definition may exist. The following changes have been made: i. each machine definition now uses a type from the MachineType enumeration instead of any random identifier. This required changing the grammar and the *.sm files. ii. MachineType enumeration defined statically in RubySlicc_Exports.sm. Diffs * src/mem/protocol/MESI_Two_Level-L1cache.sm (fea29fc045ee) * src/mem/protocol/MESI_Two_Level-L2cache.sm (fea29fc045ee) * src/mem/protocol/MESI_Two_Level-dir.sm (fea29fc045ee) * src/mem/protocol/MESI_Two_Level-dma.sm (fea29fc045ee) * src/mem/protocol/RubySlicc_Exports.sm (fea29fc045ee) * src/mem/slicc/ast/DeclListAST.py (fea29fc045ee) * src/mem/slicc/ast/MachineAST.py (fea29fc045ee) * src/mem/slicc/parser.py (fea29fc045ee) * src/mem/slicc/symbols/SymbolTable.py (fea29fc045ee) * src/mem/slicc/symbols/Type.py (fea29fc045ee) View Diff<http://reviews.gem5.org/r/2551/diff/> _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
