----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2806/ -----------------------------------------------------------
Review request for Default. Repository: gem5 Description ------- Changeset 10863:afeee121918e --------------------------- ruby: fix deadlock bug in banked array resource checks The Ruby banked array resource checks (initiated from SLICC) did a check and allocate at the same time. If a transition needs more than one resource, then it might check/allocate resource #1, then fail to get resource #2. Another transition might then try to get the same resources, but in reverse order. Deadlock. This patch separates resource checking and resource reservation into two steps to avoid deadlock. Diffs ----- src/mem/ruby/structures/CacheMemory.hh fbdaa08aaa426b9f4660c366f934ccb670d954ec src/mem/ruby/structures/CacheMemory.cc fbdaa08aaa426b9f4660c366f934ccb670d954ec src/mem/protocol/RubySlicc_Types.sm fbdaa08aaa426b9f4660c366f934ccb670d954ec src/mem/ruby/structures/BankedArray.hh fbdaa08aaa426b9f4660c366f934ccb670d954ec src/mem/ruby/structures/BankedArray.cc fbdaa08aaa426b9f4660c366f934ccb670d954ec Diff: http://reviews.gem5.org/r/2806/diff/ Testing ------- Thanks, Anthony Gutierrez _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
