> On May 12, 2015, 2:15 p.m., Joel Hestness wrote: > > src/mem/ruby/system/System.cc, line 160 > > <http://reviews.gem5.org/r/2812/diff/1/?file=45096#file45096line160> > > > > I'm not clear why it is necessary to serialize/unserialize m_phys_mem. > > It is a SimpleMemory object, which inherits the empty serialize/unserialize > > functions from Serializable. All the serialize function will do is write > > the system.ruby.phys_mem header to the checkpoint. No other state is stored > > as a result of this call. Am I missing something? > > > > I also prompted this on a prior review request here, but didn't receive > > a response: http://reviews.gem5.org/r/2627/
Haha, yeah. I had a patch with exactly this code. IIRC, you can remove it and it works exactly the same, though I could be wrong. I believe checkpoint/restore works fine with the backing store in the current mainline gem5. At least, it does the last time I tested it a couple of months ago. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2812/#review6156 ----------------------------------------------------------- On May 11, 2015, 10:20 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2812/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 10:20 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10869:9c32bcb74db9 > --------------------------- > Backing store: Serialize/unserialize backing store > > While using backing store, serialize/unserialize backing store. > > > Diffs > ----- > > src/mem/ruby/system/System.cc fbdaa08aaa426b9f4660c366f934ccb670d954ec > > Diff: http://reviews.gem5.org/r/2812/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
