----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2808/#review6193 -----------------------------------------------------------
Ship it! Similar to a couple of the other patches, it would be great if this SLICC change was documented on the wiki. This adds a new builtin function to SLICC, right? Could you make this more explicit in the commit message? Something like "This adds the "void stallPort()" builtin function that can be called from the in_port logic or an action." Or whatever is appropriate. - Jason Power On May 11, 2015, 10:23 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2808/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 10:23 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10865:959f954b7dca > --------------------------- > slicc: improved stalling support in protocols > > Adds features to allow protocols to reschedule controllers when conditionally > stalling within inport logic or actions. Also insures that resource and > protocol stalls are re-evaluated the next cycle. > > > Diffs > ----- > > src/mem/slicc/parser.py fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/slicc/ast/InPortDeclAST.py fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/slicc/ast/IsValidPtrExprAST.py > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/slicc/ast/__init__.py fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/slicc/ast/FuncCallExprAST.py > fbdaa08aaa426b9f4660c366f934ccb670d954ec > > Diff: http://reviews.gem5.org/r/2808/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
