----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2802/#review6209 -----------------------------------------------------------
src/mem/ruby/structures/CacheMemory.hh (line 137) <http://reviews.gem5.org/r/2802/#comment5374> Can you add a comment here describing what this function does? I don't find it self explanatory from the function name/parameters. E.g., what is the "idx" parameter? What is the min/max value (0 to getNumBlocks()-1, I assume)? Also, could you specify the mapping from idx to way/set (in the comment)? It's in the code, but the code is not easily parsable, at least to me. Also, are you really getting the index, or are you getting the address at a specific index? Maybe a more precise name is needed as well. - Jason Power On May 11, 2015, 10:21 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2802/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 10:21 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10859:15ac45ed4273 > --------------------------- > ruby: speed up function used for cache walks > > This patch adds a few helpful functions that allow .sm files to directly > invalidate all cache blocks using a trigger queue rather than rely on each > individual cache block to be invalidated via requests from the mandatory > queue. > > > Diffs > ----- > > src/mem/protocol/RubySlicc_Types.sm > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/ruby/structures/CacheMemory.hh > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/ruby/structures/CacheMemory.cc > fbdaa08aaa426b9f4660c366f934ccb670d954ec > > Diff: http://reviews.gem5.org/r/2802/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
