----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2809/#review6210 -----------------------------------------------------------
src/mem/ruby/network/garnet/fixed-pipeline/flit_d.hh (line 76) <http://reviews.gem5.org/r/2809/#comment5375> Suppose, you need to add two cycles, would you write a function advance_stage_two_cycles()? Write a separate patch that changes the function advance_stage() so that it sets m_stage.second to the second parameter of the function. Then, change every single place where advance_stage is called and add a cycle to the argument being passed. In this patch (2809), remove that cycle from being added. - Nilay Vaish On May 11, 2015, 10:19 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2809/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 10:19 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10866:d6df486c8ccc > --------------------------- > ruby: change router pipeline stages to 2 > > This patch changes the router pipeline stages from 4 to 2. The > canonical 4-stage router is conservative while a lower-latency router > with look ahead routing and speculative allocation is well acknowledged. > > > Diffs > ----- > > src/mem/ruby/network/garnet/fixed-pipeline/OutputUnit_d.hh > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/ruby/network/garnet/fixed-pipeline/OutputUnit_d.cc > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/ruby/network/garnet/fixed-pipeline/Router_d.hh > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/ruby/network/garnet/fixed-pipeline/Router_d.cc > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/ruby/network/garnet/fixed-pipeline/SWallocator_d.cc > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/ruby/network/garnet/fixed-pipeline/Switch_d.cc > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/ruby/network/garnet/fixed-pipeline/VCallocator_d.cc > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/ruby/network/garnet/fixed-pipeline/VirtualChannel_d.hh > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/ruby/network/garnet/fixed-pipeline/VirtualChannel_d.cc > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/ruby/network/garnet/fixed-pipeline/flit_d.hh > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/ruby/network/garnet/fixed-pipeline/InputUnit_d.cc > fbdaa08aaa426b9f4660c366f934ccb670d954ec > > Diff: http://reviews.gem5.org/r/2809/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
