----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2761/#review6331 -----------------------------------------------------------
src/cpu/kvm/base.cc (line 819) <http://reviews.gem5.org/r/2761/#comment5468> Instead of csprintf, would std::setbase(16) be a better choice here? - Alexandru Dutu On May 7, 2015, 10:59 a.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2761/ > ----------------------------------------------------------- > > (Updated May 7, 2015, 10:59 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10838:27644550a9ac > --------------------------- > kvm: Fix dumping code for large registers > > The register dumping code in kvm tries to print the bytes in large > registers (128 bits and larger) instead of printing them as hex. This > changeset fixes that. > > > Diffs > ----- > > src/cpu/kvm/base.cc fbdaa08aaa42 > > Diff: http://reviews.gem5.org/r/2761/diff/ > > > Testing > ------- > > ARM regressions pass. All backends build. Register dumping tested on ARMv8. > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
