----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2797/#review6343 -----------------------------------------------------------
At a high-level, I like that you're breaking out the replacement policies this way. However, I really dislike that you have to add 3 new lines for every single controller you create in the config files. Not only is this kind of ugly since it's lots of replicated code, but it also affects all of us with our own protocols significantly. I'll be able to spend some time tomorrow morning trying to come up with a reasonable solution (or decide it's impossible and give a "ship it" as is). It should be possible to encapsulate the duplicated code in the SimObject Python file. - Jason Power On May 11, 2015, 10:21 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2797/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 10:21 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10854:8d7e13abf092 > --------------------------- > ruby: initalize replacement policies with their own simobjs > > This is in preparation for other replacement policies that take aditional > paramters > > > Diffs > ----- > > src/mem/ruby/structures/LRUPolicy.hh > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/ruby/structures/LRUPolicy.cc PRE-CREATION > src/mem/ruby/structures/LRUReplacementPolicy.py PRE-CREATION > src/mem/ruby/structures/PseudoLRUPolicy.hh > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/ruby/structures/PseudoLRUPolicy.cc PRE-CREATION > src/mem/ruby/structures/PseudoLRUReplacementPolicy.py PRE-CREATION > src/mem/ruby/structures/ReplacementPolicy.py PRE-CREATION > src/mem/ruby/structures/SConscript fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/ruby/structures/Cache.py fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/ruby/structures/CacheMemory.hh > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/ruby/structures/CacheMemory.cc > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/ruby/structures/AbstractReplacementPolicy.hh > fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/mem/ruby/structures/AbstractReplacementPolicy.cc PRE-CREATION > configs/ruby/MESI_Two_Level.py fbdaa08aaa426b9f4660c366f934ccb670d954ec > configs/ruby/MI_example.py fbdaa08aaa426b9f4660c366f934ccb670d954ec > configs/ruby/MOESI_CMP_directory.py > fbdaa08aaa426b9f4660c366f934ccb670d954ec > configs/ruby/MOESI_CMP_token.py fbdaa08aaa426b9f4660c366f934ccb670d954ec > configs/ruby/MOESI_hammer.py fbdaa08aaa426b9f4660c366f934ccb670d954ec > > Diff: http://reviews.gem5.org/r/2797/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
