----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2838/#review6354 -----------------------------------------------------------
src/cpu/kvm/base.cc (line 539) <http://reviews.gem5.org/r/2838/#comment5477> "complete any pending IO" right? - Alexandru Dutu On May 18, 2015, 12:31 p.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2838/ > ----------------------------------------------------------- > > (Updated May 18, 2015, 12:31 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10850:2dca1e24a806 > --------------------------- > kvm: Handle inst events at the current instruction count > > There are cases (particularly when attaching GDB) when instruction > events are scheduled at the current instruction tick. This used to > trigger an assertion error in kvm. This changeset adds a check for > this condition and forces KVM to do a quick entry that completes any > pending IO operations, but does not execute any new instructions, > before servicing the event. We could check if we need to enter KVM at > all, but forcing a quick entry is makes the code slightly cleaner and > does not hurt correctness (performance is hardly an issue in these > cases). > > > Diffs > ----- > > src/cpu/kvm/base.cc 9b424e7adac5 > > Diff: http://reviews.gem5.org/r/2838/diff/ > > > Testing > ------- > > Extensively tested with kvm and gdb on aarch64. Doesn't fixes the assertion > error mentioned in the description. > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
