> On May 14, 2015, 1:56 p.m., Nilay Vaish wrote: > > I think it is not just enabling local variables for action blocks. > > My understanding is that this patch allows declaration of local > > variables without initialization. My question is would you not > > know the initial value or some default value in each case. > > Brad Beckmann wrote: > You could make that argument independent of SLICC, yet many programming > languages allow such local variable declarations. This feature simply allows > SLICC to do the same.
On Tues, 5/19 Nilay wrote via email "I agree with you. But I think you can declare local variables even now, whether initialized or uninitialized. This change would prevent the warning from getting printed when the variable is not initialized. So, the patch description is misleading." Would it help if we updated the patch description to say: slicc: remove unitialized local variable warnings in action blocks - Brad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2798/#review6258 ----------------------------------------------------------- On May 11, 2015, 10:21 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2798/ > ----------------------------------------------------------- > > (Updated May 11, 2015, 10:21 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10855:e73aade25474 > --------------------------- > slicc: support for local variable declarations in action blocks > > > Diffs > ----- > > src/mem/slicc/ast/ExprStatementAST.py > fbdaa08aaa426b9f4660c366f934ccb670d954ec > > Diff: http://reviews.gem5.org/r/2798/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
