On Tue, 26 May 2015, Joel Hestness wrote:
On May 26, 2015, 5:11 p.m., Nilay Vaish wrote:
I went through both the patches. Unlikely that I am going to agree
these changes since we are dropping the functionality of connecting buffers
in python.
Thanks for reviewing this quickly. Before I spend the time to address
the rest of your changes, I'd prefer to know more about why we're
"connecting" buffers to ports in Python code. Connecting buffers to
ports in Python is very confusing (buffers do not expose a port
interface), and the code in pyobject.cc doesn't actually do anything
with the port to which the buffer is connected. Can you elaborate why we
do that and why it shouldn't be dropped?
When connections are made in the code produced by SLICC, those connections
are not visible in config.ini and connections can only be between a
controller and the network object. The master / slave python port
interface that currently exists allows those connections to be visible in
config.ini and we can connect any message buffer to any other message
buffer and not just the buffers belonging to the network object.
--
Nilay
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
