----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2847/#review6407 -----------------------------------------------------------
Ship it! src/mem/ruby/network/garnet/fixed-pipeline/flit_d.hh (line 69) <http://reviews.gem5.org/r/2847/#comment5512> Please change the name of the parameter from curTime to something else. - Nilay Vaish On May 27, 2015, 4:48 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2847/ > ----------------------------------------------------------- > > (Updated May 27, 2015, 4:48 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10844:5a956f83fec5 > --------------------------- > ruby: change advance_stage for flit_d > > Sets m_stage.second to the second parameter of the function. > Then, for every place where advance_stage is called, adds > a cycle to the argument being passed. > > > Diffs > ----- > > src/mem/ruby/network/garnet/fixed-pipeline/InputUnit_d.cc > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/ruby/network/garnet/fixed-pipeline/RoutingUnit_d.cc > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/ruby/network/garnet/fixed-pipeline/SWallocator_d.cc > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/ruby/network/garnet/fixed-pipeline/Switch_d.cc > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/ruby/network/garnet/fixed-pipeline/VirtualChannel_d.cc > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/ruby/network/garnet/fixed-pipeline/flit_d.hh > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > > Diff: http://reviews.gem5.org/r/2847/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
