> On May 12, 2015, 10:02 p.m., Jason Power wrote: > > src/mem/slicc/symbols/StateMachine.py, line 957 > > <http://reviews.gem5.org/r/2789/diff/1/?file=45007#file45007line957> > > > > I think this should be panic, not fatal. It's on the border so I could > > easily be persuaded. But I think it would be useful to have an abort() > > here, not an exit(1) call. Note: [8.1 Fatal v. > > Panic](http://gem5.org/Coding_Style#Fatal_v._Panic). It's mostly that this > > error happens during runtime, not at configuration time, that makes me > > think it should be a panic. (It's also a panic below in the other case of a > > failure.) > > Brad Beckmann wrote: > I completely understand your point, but invalid protocol transitions also > invoke a fatal. > > If I change this error to panic, we should also change the invalid > transistion error. Do you agree with making them both panics? > > Brad Beckmann wrote: > Ping??? I'm interested to get people's thoughts here. > > Jason Power wrote: > Sorry for the slow response. Yes, I agree with making them both panic.
Any other comments on this patch? Is everyone else ok that we make all these fatals panics instead? - Brad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2789/#review6216 ----------------------------------------------------------- On May 26, 2015, 7:45 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2789/ > ----------------------------------------------------------- > > (Updated May 26, 2015, 7:45 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10819:2f5c6078ccc8 > --------------------------- > slicc: support for multiple message types on the same buffer > > This patch allows SLICC protocols to use more than one message type with a > message buffer. For example, you can declare two in ports as such: > > in_port(ResponseQueue_in, ResponseMsg, responseFromDir, rank=3) { ... } > in_port(tgtResponseQueue_in, TgtResponseMsg, responseFromDir, rank=2) { ... > } > > > Diffs > ----- > > src/mem/ruby/slicc_interface/AbstractController.hh > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/slicc/ast/InPortDeclAST.py df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/slicc/ast/PeekStatementAST.py > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/slicc/symbols/StateMachine.py > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/slicc/symbols/Var.py df2aa91dba5b0f0baa351039f0802baad9ed8f1d > src/mem/protocol/RubySlicc_Exports.sm > df2aa91dba5b0f0baa351039f0802baad9ed8f1d > > Diff: http://reviews.gem5.org/r/2789/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
