----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2823/#review6444 -----------------------------------------------------------
src/cpu/o3/cpu.cc (line 1647) <http://reviews.gem5.org/r/2823/#comment5529> Just because I ended up debugging similar things.. it might be worthwhile checking that indeed tc->threadId() always corresponds to the position of the tc in the core's threadContexts vector. I could not convince myself of that (thanks to the many layers of wrapping here), so I think you should explicitly describe why this is reasonable to expect / not expect it here. - Stephan Diestelhorst On May 12, 2015, 8:33 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2823/ > ----------------------------------------------------------- > > (Updated May 12, 2015, 8:33 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10866:4d871ca1c568 > --------------------------- > O3 CPU: Adding thread specific wakeup functionality > > The existing "wakeup" implementation was activating only thread 0's > thread context. This patch adds functionality to activate any thread's > thread context. > > > Diffs > ----- > > src/cpu/base.hh fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/cpu/o3/cpu.hh fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/cpu/o3/cpu.cc fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/cpu/simple/base.hh fbdaa08aaa426b9f4660c366f934ccb670d954ec > src/cpu/simple/base.cc fbdaa08aaa426b9f4660c366f934ccb670d954ec > > Diff: http://reviews.gem5.org/r/2823/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
