> On May 12, 2015, 3:58 p.m., Nilay Vaish wrote: > > I don't see the point of pushing this unless you show us how it is being > > used. > > Brad Beckmann wrote: > Isn't obvious how it would be used? Eventually we will post code that > uses it, but we already have 40+ patches on reviewboard. We would like to > complete this first stage before we post our next stage. > > Brad Beckmann wrote: > On 5/12 Nilay said "No, it is not obvious to me why this patch is useful. > Since the code using this patch has not been posted on the reviewboard, this > patch would not be reviewed and hence should not be committed till subsequent > patches using this code are posted." > > Nilay, we will be posting code that uses this patch in the coming months. > There is no cost to you for allowing this patch to be added and it will > significantly benefit our release process. I would greatly appreciate it if > you didn't protest this rather simple and harmless patch. Thanks!
What's the harm in moving this patch farther back in your queue? There should be no merge conflicts until it is actually used, at which point, we will be able to see review requests that use it. - Joel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2822/#review6178 ----------------------------------------------------------- On May 26, 2015, 8:02 p.m., Tony Gutierrez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2822/ > ----------------------------------------------------------- > > (Updated May 26, 2015, 8:02 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10834:fd85445fafbe > --------------------------- > config: add base class for ruby controllers > > The CntrlBase python class handles configuration parameters such as running > counts of controllers and sequencers. > > > Diffs > ----- > > configs/ruby/CntrlBase.py PRE-CREATION > > Diff: http://reviews.gem5.org/r/2822/diff/ > > > Testing > ------- > > > Thanks, > > Tony Gutierrez > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
