----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2862/#review6483 -----------------------------------------------------------
src/mem/protocol/MOESI_CMP_token-L2cache.sm (line 160) <http://reviews.gem5.org/r/2862/#comment5562> Hello Joel, Is it necessary to access the DirEntry by "getDirEntry(addr)" funciton always? Doesn't localDirectory[addr] work anymore? I am trying to quantify the number of changes I need to make in slicc files if I accept this patch in lieu of http://reviews.gem5.org/r/2786/. - Sooraj Puthoor On May 29, 2015, 2:47 p.m., Joel Hestness wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2862/ > ----------------------------------------------------------- > > (Updated May 29, 2015, 2:47 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10850:b88527f91254 > --------------------------- > ruby: Change PerfectCacheMemory::lookup to return pointer > > CacheMemory and DirectoryMemory lookup functions return pointers to entries > stored in the memory. Bring PerfectCacheMemory in line with this convention, > and clean up SLICC code generation that was in place solely to handle > references like that which was returned by PerfectCacheMemory::lookup. > > > Diffs > ----- > > src/mem/protocol/MOESI_CMP_directory-L2cache.sm e61f847e74fd > src/mem/protocol/MOESI_CMP_token-L2cache.sm e61f847e74fd > src/mem/ruby/structures/PerfectCacheMemory.hh e61f847e74fd > src/mem/slicc/ast/MethodCallExprAST.py e61f847e74fd > > Diff: http://reviews.gem5.org/r/2862/diff/ > > > Testing > ------- > > Build and run tests with all protocols. > > Please consider this patch in leiu of http://reviews.gem5.org/r/2786/ > > > Thanks, > > Joel Hestness > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
