> On June 15, 2015, 7:28 p.m., Andreas Sandberg wrote: > > configs/example/se.py, line 237 > > <http://reviews.gem5.org/r/2849/diff/2/?file=45922#file45922line237> > > > > This seems a bit smelly. Shouldn't you at least provide a warning if > > this happens? I'd almost consider it a fatal error.
I don't see a good reason to provide a warning. Just because we are initializing the cpu object with a bogus process it does not mean that the process will start executing. Clone will make sure later on that the process is switched with a valid one and only then execution is started. > On June 15, 2015, 7:28 p.m., Andreas Sandberg wrote: > > src/cpu/o3/cpu.cc, line 364 > > <http://reviews.gem5.org/r/2849/diff/2/?file=45923#file45923line364> > > > > Will this still be empty? Won't this just reuse an existing workload? Again, this will not start executing. Clone will make sure the right process will execute. Unfortunately, the CPU model constructor requires a workload to be assigned and passing a NULL will cause problems for other threads when the TLBs are initialize if I remember correctly. - Alexandru ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2849/#review6482 ----------------------------------------------------------- On June 1, 2015, 2:07 p.m., Alexandru Dutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2849/ > ----------------------------------------------------------- > > (Updated June 1, 2015, 2:07 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10858:cc93e6609fc3 > --------------------------- > config, SMT: Enabling SMT for multi-threaded programs > This patch helps enabling SMT by adding a new argument to specify the number > of hardware threads. > > > Diffs > ----- > > configs/common/Options.py d02b45a554b52c68cce41e1b3895fb8582a639dd > configs/example/se.py d02b45a554b52c68cce41e1b3895fb8582a639dd > src/cpu/o3/cpu.cc d02b45a554b52c68cce41e1b3895fb8582a639dd > src/cpu/o3/inst_queue_impl.hh d02b45a554b52c68cce41e1b3895fb8582a639dd > > Diff: http://reviews.gem5.org/r/2849/diff/ > > > Testing > ------- > > Quick regressions passed for all ISAs. > > > Thanks, > > Alexandru Dutu > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
