----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2753/#review6496 -----------------------------------------------------------
Most of the comments made below are on formatting. As you fix these, I'll try to understand the code and if required, provide you comments about the actual implementation itself. util/tlm/README (line 50) <http://reviews.gem5.org/r/2753/#comment5570> I am not able to figure in which step this executable was created. util/tlm/main.cc (line 307) <http://reviews.gem5.org/r/2753/#comment5582> No commented code. util/tlm/run_gem5.sh (line 23) <http://reviews.gem5.org/r/2753/#comment5581> No commented code. util/tlm/sc_port.cc (line 472) <http://reviews.gem5.org/r/2753/#comment5580> Inconsistent formatting. util/tlm/sc_port.cc (line 558) <http://reviews.gem5.org/r/2753/#comment5579> There should not be any space between ( and params. util/tlm/sc_target.cc (line 85) <http://reviews.gem5.org/r/2753/#comment5573> Remove this line. util/tlm/sc_target.cc (line 89) <http://reviews.gem5.org/r/2753/#comment5574> if (false)? util/tlm/sc_target.cc (line 95) <http://reviews.gem5.org/r/2753/#comment5575> if (false)? util/tlm/sc_target.cc (line 112) <http://reviews.gem5.org/r/2753/#comment5577> There should not be any space before trans. util/tlm/sc_target.cc (line 136) <http://reviews.gem5.org/r/2753/#comment5576> Inconsistent formatting of {} util/tlm/sc_target.cc (line 176) <http://reviews.gem5.org/r/2753/#comment5578> Seems all arguments can fit in the same line. util/tlm/tgen.cfg (line 1) <http://reviews.gem5.org/r/2753/#comment5572> Copyright notice missing. util/tlm/tlm.py (line 60) <http://reviews.gem5.org/r/2753/#comment5571> Seems more than 80 characters. - Nilay Vaish On June 16, 2015, 9:18 p.m., Matthias Jung wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2753/ > ----------------------------------------------------------- > > (Updated June 16, 2015, 9:18 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10873:745081501481 > --------------------------- > misc: Coupling gem5 with SystemC TLM2.0 > Transaction Level Modeling (TLM2.0) is widely used in industry for creating > virtual platforms (IEEE 1666 SystemC). This patch contains a standard > compliant > implementation of an external gem5 port, that enables the usage of gem5 as a > TLM initiator component in SystemC based virtual platforms. Both TLM coding > paradigms loosely timed (b_transport) and aproximately timed (nb_transport) > are > supported. > > A TLM memory manager was added in the latest patch. > Next step is to get rid of the transaction object and attach the gem5 packet > to the generic payload as an extension. > > > Diffs > ----- > > util/tlm/run_gem5.sh PRE-CREATION > util/tlm/sc_mm.hh PRE-CREATION > util/tlm/sc_mm.cc PRE-CREATION > util/tlm/sc_port.hh PRE-CREATION > util/tlm/sc_port.cc PRE-CREATION > util/tlm/sc_target.hh PRE-CREATION > util/tlm/sc_target.cc PRE-CREATION > util/tlm/tgen.cfg PRE-CREATION > util/tlm/tlm.py PRE-CREATION > configs/common/MemConfig.py 9141d87c7f71 > configs/common/Options.py 9141d87c7f71 > util/tlm/Makefile PRE-CREATION > util/tlm/README PRE-CREATION > util/tlm/main.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/2753/diff/ > > > Testing > ------- > > > Thanks, > > Matthias Jung > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
