----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2867/#review6507 -----------------------------------------------------------
Ship it! The change to SConstruct looks fine. Since the library itself goes into ext/, I am not going to look through it. - Nilay Vaish On June 8, 2015, 11:15 a.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2867/ > ----------------------------------------------------------- > > (Updated June 8, 2015, 11:15 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10868:b611a048f6a6 > --------------------------- > ext: Add the NoMali GPU no-simulation library > > Add revision 9adf9d6e2d889a483a92136c96eb8a434d360561 of NoMali-model > from https://github.com/ARM-software/nomali-model. This library > implements the register interface of the Mali T6xx/T7xx series GPUs, > but doesn't do any rendering. It can be used to hide the effects of > software rendering. > > > Note: The NoMali library is under an Apache v2 license. > > > Diffs > ----- > > ext/nomali/lib/jobcontrol.cc PRE-CREATION > ext/nomali/lib/jobslot.hh PRE-CREATION > ext/nomali/lib/jobslot.cc PRE-CREATION > ext/nomali/lib/mali_midg_regmap.h PRE-CREATION > ext/nomali/lib/mali_midgard.hh PRE-CREATION > ext/nomali/lib/mali_midgard.cc PRE-CREATION > ext/nomali/lib/mali_t6xx.hh PRE-CREATION > ext/nomali/lib/mali_t6xx.cc PRE-CREATION > ext/nomali/lib/mali_t7xx.hh PRE-CREATION > ext/nomali/lib/mali_t7xx.cc PRE-CREATION > ext/nomali/lib/mmu.hh PRE-CREATION > ext/nomali/lib/mmu.cc PRE-CREATION > ext/nomali/lib/nomali_api.cc PRE-CREATION > ext/nomali/lib/regutils.hh PRE-CREATION > ext/nomali/lib/types.hh PRE-CREATION > ext/nomali/tests/Rules.mk PRE-CREATION > ext/nomali/tests/nomali_test0.c PRE-CREATION > ext/nomali/tests/nomali_test_helpers.h PRE-CREATION > ext/nomali/tests/nomali_test_ints.c PRE-CREATION > ext/nomali/tests/test_helpers.h PRE-CREATION > ext/nomali/tests/test_helpers.c PRE-CREATION > ext/nomali/lib/gpublock.hh PRE-CREATION > ext/nomali/lib/gpublock.cc PRE-CREATION > ext/nomali/lib/gpucontrol.hh PRE-CREATION > ext/nomali/lib/gpucontrol.cc PRE-CREATION > ext/nomali/lib/jobcontrol.hh PRE-CREATION > ext/nomali/lib/gpu.hh PRE-CREATION > ext/nomali/lib/gpu.cc PRE-CREATION > ext/nomali/doxygen.sed PRE-CREATION > ext/nomali/include/libnomali/nomali.h PRE-CREATION > ext/nomali/lib/Rules.mk PRE-CREATION > ext/nomali/Rules.app.mk PRE-CREATION > ext/nomali/Rules.lib.mk PRE-CREATION > ext/nomali/SConscript PRE-CREATION > SConstruct 282c2a89ace8 > ext/nomali/.gitignore PRE-CREATION > ext/nomali/Doxyfile PRE-CREATION > ext/nomali/LICENSE PRE-CREATION > ext/nomali/Makefile PRE-CREATION > > Diff: http://reviews.gem5.org/r/2867/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
