----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2903/#review6514 -----------------------------------------------------------
Ship it! Awesome. Always good to see a global variable go away. To add on to Nilay, I'd suggest a better name while we're at it. What is "abs"? abstract? absolute? I'd go with "all_controllers", but I'm ok with how it is too. - Jason Power On June 19, 2015, 4:40 a.m., Brandon Potter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2903/ > ----------------------------------------------------------- > > (Updated June 19, 2015, 4:40 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10878:9b1f89a1a3a8 > --------------------------- > ruby: move g_abs_controls from global into RubySystem > > > Diffs > ----- > > src/cpu/testers/directedtest/RubyDirectedTester.hh > ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/cpu/testers/rubytest/Check.hh ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/cpu/testers/rubytest/CheckTable.hh > ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/cpu/testers/rubytest/RubyTester.hh > ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/cpu/testers/rubytest/RubyTester.cc > ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/mem/ruby/common/Global.hh ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/mem/ruby/common/Global.cc ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/mem/ruby/common/SConscript ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc > ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/mem/ruby/network/garnet/fixed-pipeline/OutVcState_d.cc > ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc > ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/mem/ruby/network/simple/Throttle.hh > ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/mem/ruby/profiler/AccessTraceForAddress.hh > ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/mem/ruby/profiler/Profiler.hh ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/mem/ruby/profiler/Profiler.cc ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/mem/ruby/structures/RubyMemoryControl.hh > ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/mem/ruby/structures/RubyMemoryControl.cc > ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/mem/ruby/structures/TimerTable.cc > ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/mem/ruby/system/Sequencer.cc ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/mem/ruby/system/System.hh ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/mem/slicc/symbols/StateMachine.py > ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > src/mem/slicc/symbols/Type.py ebb3d0737aa72ec4fa24b6af9cf9a6b2a1109d18 > > Diff: http://reviews.gem5.org/r/2903/diff/ > > > Testing > ------- > > > Thanks, > > Brandon Potter > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
