----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2859/#review6529 -----------------------------------------------------------
Ship it! Seems fine. - Nilay Vaish On May 28, 2015, 3:41 p.m., Alexandru Dutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2859/ > ----------------------------------------------------------- > > (Updated May 28, 2015, 3:41 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10865:ea6f1011ab07 > --------------------------- > cpu, o3: Remove assertion on buffer from rename being empty > This patch removes assertion in sortInsts() regarding the insts buffer from > rename to issue being empty. The assertion makes little sense as insts, the > queue used to buffer instructions from rename to iew should not be empty in > every tick of iew. Issue can be slower than rename. > > > Diffs > ----- > > src/cpu/o3/iew_impl.hh d02b45a554b52c68cce41e1b3895fb8582a639dd > > Diff: http://reviews.gem5.org/r/2859/diff/ > > > Testing > ------- > > Quick regressions passed for all ISAs. > > > Thanks, > > Alexandru Dutu > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
