----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2881/#review6538 -----------------------------------------------------------
Ship it! Ship It! - Nilay Vaish On June 9, 2015, 12:41 p.m., Nikos Nikoleris wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2881/ > ----------------------------------------------------------- > > (Updated June 9, 2015, 12:41 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10866:da8b24145579 > --------------------------- > x86: Adjust the size of the values written to the x87 misc registers > > All x87 misc registers are implemented in an array of 64 bit values > but in real hardware the size of some of these registers is smaller. > Previsouly all 64 bits where incorrectly set and then later read. To > ensure correctness we mask the value in setMiscRegNoEffect to write > only the valid bits. > > > Diffs > ----- > > src/arch/x86/isa.cc fbdaa08aaa42 > > src/arch/x86/isa/insts/simd128/integer/save_and_restore_state/save_and_restore_state.py > fbdaa08aaa42 > src/arch/x86/isa/insts/x87/control/save_and_restore_x87_environment.py > fbdaa08aaa42 > > Diff: http://reviews.gem5.org/r/2881/diff/ > > > Testing > ------- > > > Thanks, > > Nikos Nikoleris > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
