----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2856/#review6569 -----------------------------------------------------------
Ship it! I'm happy with this. I agree with Nilay that the difference in naming is a bit unfortunate. It'd probably make sense to rename the methods in fetch so they use the suspend/activate terminology and implement quiesce using that. That's a different commit though. - Andreas Sandberg On May 28, 2015, 4:40 p.m., Alexandru Dutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2856/ > ----------------------------------------------------------- > > (Updated May 28, 2015, 4:40 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10862:c32578991199 > --------------------------- > cpu: o3: Commit stage updates for hw threads priority list > This patch makes sure the priority_list in the fetch stage is kept in sync > with suspendContext and activateContext calls. > > > Diffs > ----- > > src/cpu/o3/commit.hh d02b45a554b52c68cce41e1b3895fb8582a639dd > src/cpu/o3/commit_impl.hh d02b45a554b52c68cce41e1b3895fb8582a639dd > src/cpu/o3/cpu.cc d02b45a554b52c68cce41e1b3895fb8582a639dd > > Diff: http://reviews.gem5.org/r/2856/diff/ > > > Testing > ------- > > Quick regressions passed for all ISAs. > > > Thanks, > > Alexandru Dutu > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev