----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2826/#review6528 -----------------------------------------------------------
There are several style issues. The writer should read gem5.org/Coding_Style. I am still trying to understand all the synchronization code. So it will take me sometime before I am able to review that code. src/dev/etherpkt.hh (lines 78 - 79) <http://reviews.gem5.org/r/2826/#comment5676> store not strore in these two lines. src/dev/multi_etherlink.hh (line 112) <http://reviews.gem5.org/r/2826/#comment5677> double? The simulator does not understand fractional ticks. src/dev/multi_etherlink.hh (line 128) <http://reviews.gem5.org/r/2826/#comment5678> Please don't call it rate. In abstraction ticks per byte is also a rate, but I think the general meaning for rate is something amount of work carried out per unit time. You probably want to work with the bandwidth of the link. src/dev/multi_etherlink.cc (line 192) <http://reviews.gem5.org/r/2826/#comment5679> I think there is some confusion between what the python parameter represents and what the C++ code expects for this ticksPerByte variable. src/dev/multi_etherlink.cc (line 207) <http://reviews.gem5.org/r/2826/#comment5680> If the checkpoint patch from Andreas Sandberg goes in first, you would need to fix the serialize functions. src/dev/multi_iface.cc (line 94) <http://reviews.gem5.org/r/2826/#comment5681> indentation is of. util/multi/gem5-multi.sh (line 57) <http://reviews.gem5.org/r/2826/#comment5602> number not naumber. - Nilay Vaish On May 15, 2015, 11:38 p.m., Curtis Dunham wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2826/ > ----------------------------------------------------------- > > (Updated May 15, 2015, 11:38 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Multi gem5 is an extension to gem5 to enable parallel simulation of a > distributed system (e.g. simulation of a pool of machines > connected by Ethernet links). A multi gem5 run consists of seperate gem5 > processes running in parallel (potentially on different hosts/slots on > a cluster). Each gem5 process executes the simulation of a component of the > simulated distributed system (e.g. a multi-core board with an Ethernet NIC). > > The patch implements the "distributed" Ethernet link device > (dev/src/multi_etherlink.[hh.cc]). This device will send/receive > (simulated) Ethernet packets to/from peer gem5 processes. The interface > to talk to the peer gem5 processes is defined in dev/src/multi_iface.hh and > in tcp_iface.hh. > > There is also a central message server process (util/multi/tcp_server.[hh,cc]) > which acts like an Ethernet switch and transfers messages among the gem5 > peers. > > A multi gem5 simulations can be kicked off by the util/multi/gem5-multi.sh > wrapper script. > > Checkpoint support will follow in a subsequent patch. > > > Diffs > ----- > > src/dev/Ethernet.py 9b424e7adac570f9837cde60d619b6ec3c211854 > src/dev/SConscript 9b424e7adac570f9837cde60d619b6ec3c211854 > src/dev/etherpkt.hh 9b424e7adac570f9837cde60d619b6ec3c211854 > src/dev/etherpkt.cc 9b424e7adac570f9837cde60d619b6ec3c211854 > src/dev/multi_etherlink.hh PRE-CREATION > src/dev/multi_etherlink.cc PRE-CREATION > src/dev/multi_iface.hh PRE-CREATION > src/dev/multi_iface.cc PRE-CREATION > src/dev/multi_packet.hh PRE-CREATION > src/dev/multi_packet.cc PRE-CREATION > src/dev/tcp_iface.hh PRE-CREATION > src/dev/tcp_iface.cc PRE-CREATION > util/multi/Makefile PRE-CREATION > util/multi/bootscript.rcS PRE-CREATION > util/multi/gem5-multi.sh PRE-CREATION > util/multi/tcp_server.hh PRE-CREATION > util/multi/tcp_server.cc PRE-CREATION > > Diff: http://reviews.gem5.org/r/2826/diff/ > > > Testing > ------- > > > Thanks, > > Curtis Dunham > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
