----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2911/#review6580 -----------------------------------------------------------
src/mem/ruby/system/RubyPort.hh (line 191) <http://reviews.gem5.org/r/2911/#comment5682> A port is not allowed to send a new request until it gets a retry, so the assert is appropriate in this case. - Andreas Hansson On June 23, 2015, 9:52 p.m., Jason Power wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/2911/ > ----------------------------------------------------------- > > (Updated June 23, 2015, 9:52 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 10875:e15eea749253 > --------------------------- > Ruby: Remove assert in RubyPort retry list logic > > Remove the assert when adding a port to the RubyPort retry list. > Instead of asserting, just ignore the added port, since it's > already on the list. > Without this patch, Ruby+detailed fails for even the simplest tests > > > Diffs > ----- > > src/mem/ruby/system/RubyPort.hh e4f63f1d502d > > Diff: http://reviews.gem5.org/r/2911/diff/ > > > Testing > ------- > > build/X86_MESI_Two_Level/gem5.debug configs/example/se.py --cpu-type=detailed > --ruby -c tests/test-progs/hello/bin/x86/linux/hello now runs to completion. > > Note: this is compatible (and required) with http://reviews.gem5.org/r/2787/ > as well. > > > Thanks, > > Jason Power > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
